[SPARK-6477][Build]: Run MIMA tests before the Spark test suite#5145
Closed
brennonyork wants to merge 1 commit into
Closed
[SPARK-6477][Build]: Run MIMA tests before the Spark test suite#5145brennonyork wants to merge 1 commit into
brennonyork wants to merge 1 commit into
Conversation
Member
|
Agree, I like this one. Fail-fast checks should go first. |
|
Test build #29031 has started for PR 5145 at commit
|
|
Test build #29031 has finished for PR 5145 at commit
|
|
Test PASSed. |
Author
|
/cc @pwendell as well for any thoughts |
Contributor
|
LGTM |
Contributor
|
LGTM too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves the MIMA checks to before the full Spark test suite such that, if new PR's fail the MIMA check, they will return much faster having not run the entire test suite. This is preferable to the current scenario where a user would have to wait until the entire test suite completes before realizing it failed on a MIMA check in which case, once the MIMA issues are fixed, the user would have to resubmit and rerun the full test suite again.